Merge pull request #132 from Skylar-Tech/dev

Release v0.9.1

README.md

@@ -5,6 +5,8 @@
 
 Join our public Matrix room for help: [#node-red-contrib-matrix-chat:skylar.tech](https://app.element.io/#/room/#node-red-contrib-matrix-chat:skylar.tech)
 
+[![ko-fi](https://ko-fi.com/img/githubbutton_sm.svg)](https://ko-fi.com/B0B51BM7C)
+
 ### Features
 
 Supported functionality in this package includes:
@@ -59,7 +61,9 @@ Interested in helping? Contributions to finalize E2EE support are welcome!
 
 This module includes a node to register users using the Synapse secret registration endpoint. It returns both an `access_token` and a `device_id`, perfect for setting up the bot.
 
-[See how to register a user here](https://github.com/Skylar-Tech/node-red-contrib-matrix-chat/tree/master/examples#readme).
+[Guide on registering a user via the web browser](https://skylar.tech/matrix-chat-bot-module-for-node-red/)
+
+[Guide on registering using shared secret registration](https://github.com/Skylar-Tech/node-red-contrib-matrix-chat/tree/master/examples#readme) (for server owners)
 
 ### Other Packages
 

package.json

@@ -1,6 +1,6 @@
 {
   "name": "node-red-contrib-matrix-chat",
-  "version": "0.8.0",
+  "version": "0.9.1",
   "description": "Matrix chat server client for Node-RED",
   "dependencies": {
     "abort-controller": "^3.0.0",
@@ -9,12 +9,11 @@
     "got": "^12.0.2",
     "image-size": "^1.0.2",
     "isomorphic-webcrypto": "^2.3.8",
-    "matrix-js-sdk": "^28.0.0",
+    "matrix-js-sdk": "34.11.1",
     "mime": "^3.0.0",
     "node-fetch": "^3.3.0",
     "node-localstorage": "^2.2.1",
     "olm": "https://gitlab.matrix.org/matrix-org/olm/-/package_files/2572/download",
-    "request": "^2.88.2",
     "sharp": "^0.33.4",
     "tmp": "^0.2.1",
     "utf8": "^3.0.0"

src/matrix-event-relations.js

@@ -1,4 +1,4 @@
-const {RelationType, EventType, Direction} = require("matrix-js-sdk");
+const sdkPromise = import("matrix-js-sdk");
 
 module.exports = function(RED) {
     function MatrixFetchRelations(n) {
@@ -49,14 +49,17 @@ module.exports = function(RED) {
             }
 
             try {
+                const sdk = await sdkPromise;
+                const Direction = sdk.Direction;
+
                 function evaluateNodePropertySafe(value, type, node, msg) {
                     try {
                         return RED.util.evaluateNodeProperty(value, type, node, msg);
                     } catch (e) {
                         if (e instanceof TypeError) {
-                            return undefined;  // Handle TypeError and return undefined
+                            return undefined;
                         }
-                        throw e;  // Re-throw other errors to prevent masking issues
+                        throw e;
                     }
                 }
 
@@ -71,16 +74,16 @@ module.exports = function(RED) {
                     to = evaluateNodePropertySafe(node.toValue, node.toType, node, msg);
 
                 let opts = { dir: direction };
-                if(limit) {
+                if (limit) {
                     opts.limit = limit;
                 }
-                if(recurse === true || recurse === false) {
+                if (recurse === true || recurse === false) {
                     opts.recurse = recurse;
                 }
-                if(from) {
+                if (from) {
                     opts.from = from;
                 }
-                if(to) {
+                if (to) {
                     opts.to = to;
                 }
 

src/matrix-get-event.html

@@ -19,14 +19,18 @@
         },
         oneditprepare: function() {
             $("#node-input-roomId").typedInput({
-                type: this.roomIdType,
+                types: ['msg','flow','global','str'],
-                types:['msg','flow','global','str'],
+                typeField: "#node-input-roomId"
-            }).typedInput('value', this.roomIdValue);
+            });
+            $("#node-input-roomId").typedInput("type", this.roomIdType || "msg");
+            $("#node-input-roomId").typedInput("value", this.roomIdValue || "topic");
 
             $("#node-input-eventId").typedInput({
-                type: this.eventIdType,
+                types: ['msg','flow','global','str'],
-                types:['msg','flow','global','str'],
+                typeField: "#node-input-eventId"
-            }).typedInput('value', this.eventIdValue);
+            });
+            $("#node-input-eventId").typedInput("type", this.eventIdType || "msg");
+            $("#node-input-eventId").typedInput("value", this.eventIdValue || "eventId");
         },
         oneditsave: function() {
             this.roomIdType = $("#node-input-roomId").typedInput('type');
@@ -58,18 +62,6 @@
         <label for="node-input-eventId"><i class="fa fa-file"></i> Event ID</label>
         <input type="text" id="node-input-eventId">
     </div>
-
-    <script type="text/javascript">
-        $(function(){
-            $("#node-input-roomId").on("keyup", function() {
-                if($(this).val() && !$(this).val().startsWith("!")) {
-                    $("#node-input-roomId-error").html(`Room IDs start with exclamation point "!"<br />Example: !OGEhHVWSdvArJzumhm:matrix.org`).show();
-                } else {
-                    $("#node-input-roomId-error").hide();
-                }
-            }).trigger('keyup');
-        });
-</script>
 </script>
 
 <script type="text/html" data-help-name="matrix-get-event">

src/matrix-mark-read.js

@@ -1,9 +1,8 @@
-const {TimelineWindow, RelationType, Filter} = require("matrix-js-sdk");
 const crypto = require('crypto');
-module.exports = function(RED) {
-    function MatrixReceiveMessage(n) {
-        RED.nodes.createNode(this, n);
 
+module.exports = function(RED) {
+    function MatrixMarkRead(n) {
+        RED.nodes.createNode(this, n);
         let node = this;
         this.name = n.name;
         this.server = RED.nodes.getNode(n.server);
@@ -29,7 +28,7 @@ module.exports = function(RED) {
         });
 
         node.on("input", async function (msg) {
-            if (! node.server || ! node.server.matrixClient) {
+            if (!node.server || !node.server.matrixClient) {
                 node.error("No matrix server selected", msg);
                 return;
             }
@@ -38,15 +37,15 @@ module.exports = function(RED) {
                 let value = property;
                 if (type === "msg") {
                     value = RED.util.getMessageProperty(msg, property);
-                } else if ((type === 'flow') || (type === 'global')) {
+                } else if (type === 'flow' || type === 'global') {
                     try {
                         value = RED.util.evaluateNodeProperty(property, type, node, msg);
-                    } catch(e2) {
+                    } catch (e2) {
                         throw new Error("Invalid value evaluation");
                     }
-                } else if(type === "bool") {
+                } else if (type === "bool") {
                     value = (property === 'true');
-                } else if(type === "num") {
+                } else if (type === "num") {
                     value = Number(property);
                 }
                 return value;
@@ -66,9 +65,9 @@ module.exports = function(RED) {
                     throw new Error(`Event ${eventId} not found in room ${roomId}.`);
                 }
 
-                await node.server.matrixClient.sendReceipt(event, "m.read")
+                await node.server.matrixClient.sendReceipt(event, "m.read");
                 node.send([msg, null]);
-            } catch(e) {
+            } catch (e) {
                 msg.error = `Room pagination error: ${e}`;
                 node.error(msg.error, msg);
                 node.send([null, msg]);
@@ -79,5 +78,5 @@ module.exports = function(RED) {
             node.server.deregister(node);
         });
     }
-    RED.nodes.registerType("matrix-mark-read", MatrixReceiveMessage);
+    RED.nodes.registerType("matrix-mark-read", MatrixMarkRead);
 }

src/matrix-paginate-room.js

@@ -1,7 +1,8 @@
-const {TimelineWindow, RelationType, Filter} = require("matrix-js-sdk");
+const sdkPromise = import("matrix-js-sdk");
 const crypto = require('crypto');
+
 module.exports = function(RED) {
-    function MatrixReceiveMessage(n) {
+    function MatrixPaginateRoom(n) {
         RED.nodes.createNode(this, n);
 
         let node = this;
@@ -34,7 +35,7 @@ module.exports = function(RED) {
         });
 
         node.on("input", async function (msg) {
-            if (! node.server || ! node.server.matrixClient) {
+            if (!node.server || !node.server.matrixClient) {
                 node.error("No matrix server selected", msg);
                 return;
             }
@@ -43,43 +44,47 @@ module.exports = function(RED) {
                 let value = property;
                 if (type === "msg") {
                     value = RED.util.getMessageProperty(msg, property);
-                } else if ((type === 'flow') || (type === 'global')) {
+                } else if (type === 'flow' || type === 'global') {
                     try {
                         value = RED.util.evaluateNodeProperty(property, type, node, msg);
                     } catch(e2) {
                         throw new Error("Invalid value evaluation");
                     }
-                } else if(type === "bool") {
+                } else if (type === "bool") {
                     value = (property === 'true');
-                } else if(type === "num") {
+                } else if (type === "num") {
                     value = Number(property);
                 }
                 return value;
             }
 
             function setToValue(value, type, property) {
-                if(type === 'global' || type === 'flow') {
+                if (type === 'global' || type === 'flow') {
                     var contextKey = RED.util.parseContextStore(property);
                     if (/\[msg/.test(contextKey.key)) {
-                        // The key has a nest msg. reference to evaluate first
+                        // The key has a nested msg. reference that must be evaluated first
-                        contextKey.key = RED.util.normalisePropertyExpression(contextKey.key, msg, true)
+                        contextKey.key = RED.util.normalisePropertyExpression(contextKey.key, msg, true);
                     }
                     var target = node.context()[type];
-                    var callback = err => {
+                    target.set(contextKey.key, value, contextKey.store, err => {
                         if (err) {
                             node.error(err, msg);
-                            getterErrors[rule.p] = err.message;
                         }
-                    }
+                    });
-                    target.set(contextKey.key, value, contextKey.store, callback);
+                } else if (type === 'msg') {
-                } else if(type === 'msg') {
                     if (!RED.util.setMessageProperty(msg, property, value)) {
-                        node.warn(RED._("change.errors.no-override",{property:property}));
+                        node.warn(RED._("change.errors.no-override", { property: property }));
                     }
                 }
             }
 
             try {
+                // Dynamically load the SDK
+                const sdk = await sdkPromise;
+                const TimelineWindow = sdk.TimelineWindow;
+                const RelationType = sdk.RelationType;
+                // (Filter was imported originally but is not used, so we omit it.)
+
                 let roomId = getToValue(msg, node.roomType, node.roomValue),
                     paginateBackwards = getToValue(msg, node.paginateBackwardsType, node.paginateBackwardsValue),
                     pageSize = getToValue(msg, node.pageSizeType, node.pageSizeValue),
@@ -87,42 +92,37 @@ module.exports = function(RED) {
 
                 let room = node.server.matrixClient.getRoom(roomId);
 
-                if(!room) {
+                if (!room) {
                     throw new Error(`Room ${roomId} does not exist`);
                 }
-                if(pageSize > node.server.initialSyncLimit) {
+                if (pageSize > node.server.initialSyncLimit) {
                     throw new Error(`Page size=${pageSize} cannot exceed initialSyncLimit=${node.server.initialSyncLimit}`);
                 }
-                if(!pageKey) {
+                if (!pageKey) {
                     pageKey = crypto.randomUUID();
                     setToValue(pageKey, node.paginateKeyType, node.paginateKeyValue);
                 }
                 let timelineWindow = node.timelineWindows.get(pageKey),
                     moreMessages = true;
-                if(!timelineWindow) {
+                if (!timelineWindow) {
                     let timelineSet = room.getUnfilteredTimelineSet();
-                    // node.debug(JSON.stringify(timelineSet.getFilter()));
+                    // MatrixClient's option initialSyncLimit gets set to the filter we are using,
-
+                    // so override that value with our pageSize.
-                    // MatrixClient's option initialSyncLimit gets set to the filter we are using
-                    // so override that value with our pageSize
                     timelineWindow = new TimelineWindow(node.server.matrixClient, timelineSet);
                     await timelineWindow.load(msg.eventId || null, pageSize);
                     node.timelineWindows.set(pageKey, timelineWindow);
                 } else {
-                    moreMessages = await timelineWindow.paginate(paginateBackwards ? 'b' : 'f', pageSize); // b for backwards f for forwards
+                    moreMessages = await timelineWindow.paginate(paginateBackwards ? 'b' : 'f', pageSize); // 'b' for backwards, 'f' for forwards
-                    if(moreMessages) {
+                    if (moreMessages) {
                         await timelineWindow.unpaginate(pageSize, !paginateBackwards);
                     }
                 }
 
-                // MatrixEvent objects are massive so this throws an encode error for the string being too long
+                // To avoid errors converting massive MatrixEvent objects to JSON, we omit them.
-                // since msg objects convert to JSON
-                // msg.payload = moreMessages ? timelineWindow.getEvents() : false;
-
                 msg.payload = false;
                 msg.start = timelineWindow.getTimelineIndex('b')?.index;
                 msg.end = timelineWindow.getTimelineIndex('f')?.index;
-                if(moreMessages) {
+                if (moreMessages) {
                     msg.payload = timelineWindow.getEvents().map(function(event) {
                         return {
                             encrypted    : event.isEncrypted(),
@@ -152,5 +152,5 @@ module.exports = function(RED) {
             node.server.deregister(node);
         });
     }
-    RED.nodes.registerType("matrix-paginate-room", MatrixReceiveMessage);
+    RED.nodes.registerType("matrix-paginate-room", MatrixPaginateRoom);
 }

src/matrix-receive.html

@@ -13,6 +13,7 @@
             acceptOwnEvents: {"value": false},
             acceptText: {"value": true},
             acceptEmotes: {"value": true},
+            acceptNotices: {"value": true},
             acceptStickers: {"value": true},
             acceptReactions: {"value": true},
             acceptFiles: {"value": true},
@@ -66,6 +67,16 @@
             Accept text <code style="text-transform: none;">m.text</code>
         </label>
     </div>
+    <div class="form-row" style="margin-bottom:0;">
+        <input
+                type="checkbox"
+                id="node-input-acceptNotices"
+                style="width: auto; margin-left: 125px; vertical-align: top"
+        />
+        <label for="node-input-acceptNotices" style="width: auto">
+            Accept notices <code style="text-transform: none;">m.notice</code>
+        </label>
+    </div>
     <div class="form-row" style="margin-bottom:0;">
         <input
                 type="checkbox"

src/matrix-receive.js

@@ -1,4 +1,3 @@
-const {RelationType} = require("matrix-js-sdk");
 module.exports = function(RED) {
     function MatrixReceiveMessage(n) {
         RED.nodes.createNode(this, n);
@@ -10,6 +9,7 @@ module.exports = function(RED) {
         this.acceptOwnEvents = n.acceptOwnEvents;
         this.acceptText = n.acceptText;
         this.acceptEmotes = n.acceptEmotes;
+        this.acceptNotices = n.acceptNotices;
         this.acceptStickers = n.acceptStickers;
         this.acceptReactions = n.acceptReactions;
         this.acceptFiles = n.acceptFiles;
@@ -69,6 +69,10 @@ module.exports = function(RED) {
                     if (!node.acceptEmotes) return;
                     break;
 
+                case 'm.notice':
+                    if (!node.acceptNotices) return;
+                    break;
+
                 case 'm.text':
                     if (!node.acceptText) return;
                     break;

src/matrix-send-message.js

@@ -1,9 +1,8 @@
-const {RelationType} = require("matrix-js-sdk");
+const sdkPromise = import("matrix-js-sdk");
 
 module.exports = function(RED) {
     function MatrixSendImage(n) {
         RED.nodes.createNode(this, n);
-
         var node = this;
 
         this.name = n.name;
@@ -68,12 +67,17 @@ module.exports = function(RED) {
             node.status({ fill: "green", shape: "ring", text: "connected" });
         });
 
-        node.on("input", function (msg) {
+        // Make the input handler async so we can await the dynamic import.
+        node.on("input", async function (msg) {
+            // Await the SDK import and get the RelationType constant.
+            const sdk = await sdkPromise;
+            const RelationType = sdk.RelationType;
+
             function getToValue(msg, type, property) {
                 let value = property;
                 if (type === "msg") {
                     value = RED.util.getMessageProperty(msg, property);
-                } else if ((type === 'flow') || (type === 'global')) {
+                } else if (type === 'flow' || type === 'global') {
                     try {
                         value = RED.util.evaluateNodeProperty(property, type, node, msg);
                     } catch(e2) {
@@ -115,19 +119,19 @@ module.exports = function(RED) {
             }
 
             let content = null;
-            if(typeof payload === 'object') {
+            if (typeof payload === 'object') {
                 content = payload;
             } else {
-                if(msgType === 'msg.type') {
+                if (msgType === 'msg.type') {
-                    if(!msg.type) {
+                    if (!msg.type) {
-                        node.error("msg.type type is set to be passed in via msg.type but was not defined", msg);
+                        node.error("msg.type is set to be passed in via msg.type but was not defined", msg);
                         return;
                     }
                     msgType = msg.type;
                 }
 
-                if(msgFormat === 'msg.format') {
+                if (msgFormat === 'msg.format') {
-                    if(!msg.format) {
+                    if (!Object.hasOwn(msg, 'format')) {
                         node.error("Message format is set to be passed in via msg.format but was not defined", msg);
                         return;
                     }
@@ -139,7 +143,7 @@ module.exports = function(RED) {
                     body: payload.toString()
                 };
 
-                if(msgFormat === 'html') {
+                if (msgFormat === 'html') {
                     content.format = "org.matrix.custom.html";
                     content.formatted_body =
                         (typeof msg.formatted_payload !== 'undefined' && msg.formatted_payload)
@@ -147,15 +151,15 @@ module.exports = function(RED) {
                             : payload.toString();
                 }
 
-                if((node.replaceMessage || msg.replace) && msg.eventId) {
+                if ((node.replaceMessage || msg.replace) && msg.eventId) {
                     content['m.new_content'] = {
                         msgtype: content.msgtype,
                         body: content.body
                     };
-                    if('format' in content) {
+                    if ('format' in content) {
                         content['m.new_content']['format'] = content['format'];
                     }
-                    if('formatted_body' in content) {
+                    if ('formatted_body' in content) {
                         content['m.new_content']['formatted_body'] = content['formatted_body'];
                     }
 
@@ -164,17 +168,19 @@ module.exports = function(RED) {
                         event_id: msg.eventId
                     };
                     content['body'] = ' * ' + content['body'];
-                } else if(threadReply) {
+                } else if (threadReply) {
-                    // if incoming message is a reply to a thread we fetch the thread parent from the m.relates_to property
+                    // If incoming message is a reply to a thread we fetch the thread parent from m.relates_to,
-                    // otherwise fallback to msg.eventId
+                    // otherwise fallback to msg.eventId.
-                    let threadParent = (msg?.content?.['m.relates_to']?.rel_type === RelationType.Thread ? msg?.content?.['m.relates_to']?.event_id : null) || msg.eventId;
+                    let threadParent = (msg?.content?.['m.relates_to']?.rel_type === RelationType.Thread
-                    if(threadParent) {
+                        ? msg?.content?.['m.relates_to']?.event_id
+                        : null) || msg.eventId;
+                    if (threadParent) {
                         content["m.relates_to"] = {
                             "rel_type": RelationType.Thread,
                             "event_id": threadParent,
                             "is_falling_back": true,
                         };
-                        if(msg.eventId !== threadParent) {
+                        if (msg.eventId !== threadParent) {
                             content["m.relates_to"]["m.in_reply_to"] = {
                                 "event_id": msg.eventId
                             };
@@ -202,4 +208,4 @@ module.exports = function(RED) {
         });
     }
     RED.nodes.registerType("matrix-send-message", MatrixSendImage);
-}
+};

src/matrix-server-config.html

@@ -36,7 +36,8 @@
             name: { value: null },
             autoAcceptRoomInvites: { value: true },
             enableE2ee: { type: "checkbox", value: true },
-            global: { type: "checkbox", value: true }
+            global: { type: "checkbox", value: true },
+            allowUnknownDevices: { type: "checkbox", value: false }
         },
         icon: "matrix.png",
         label: function() {
@@ -130,6 +131,20 @@
             <code style="white-space: normal;">let client = global.get("matrixClient['@bot:example.com']");</code>
         </div>
     </div>
+
+    <div class="form-row">
+        <input
+                type="checkbox"
+                id="node-config-input-allowUnknownDevices"
+                style="width: auto; margin-left: 125px; vertical-align: top"
+        />
+        <label for="node-config-input-allowUnknownDevices" style="width: auto">
+            Allow unverified devices in rooms
+        </label>
+        <div class="form-tips" style="margin-bottom: 12px;">
+            Allow sending messages to a room with unknown devices which have not been verified.
+        </div>
+    </div>
     <script type="text/javascript">
         $("#matrix-login-btn").on("click", function() {
             function prettyPrintJson(json) {

src/matrix-server-config.js

@@ -1,33 +1,52 @@
-const {RelationType, TimelineWindow} = require("matrix-js-sdk");
-
 global.Olm = require('olm');
 const fs = require("fs-extra");
-const sdk = require("matrix-js-sdk");
+let RelationType, TimelineWindow, sdk, LocalStorageCryptoStore, RoomEvent, RoomMemberEvent, HttpApiEvent, ClientEvent, MemoryStore;
+
+(async () => {
+    const mod = await import("matrix-js-sdk");
+    RelationType = mod.RelationType;
+    TimelineWindow = mod.TimelineWindow;
+    // matrix-js-sdk doesn't export a default – the top-level export is the same object:
+    sdk = mod;
+
+    RoomEvent = mod.RoomEvent;
+    RoomMemberEvent = mod.RoomMemberEvent;
+    HttpApiEvent = mod.HttpApiEvent;
+    ClientEvent = mod.ClientEvent;
+    MemoryStore = mod.MemoryStore;
+
+    // For LocalStorageCryptoStore, specify the file extension for Node 20+:
+    const cmod = await import("matrix-js-sdk/lib/crypto/store/localStorage-crypto-store.js");
+    LocalStorageCryptoStore = cmod.LocalStorageCryptoStore;
+})();
+
 const { resolve } = require('path');
 const { LocalStorage } = require('node-localstorage');
-const { LocalStorageCryptoStore } = require('matrix-js-sdk/lib/crypto/store/localStorage-crypto-store');
-const {RoomEvent, RoomMemberEvent, HttpApiEvent, ClientEvent, MemoryStore} = require("matrix-js-sdk");
-const request = require("request");
 require("abort-controller/polyfill"); // polyfill abort-controller if we don't have it
 if (!globalThis.fetch) {
     // polyfill fetch if we don't have it
     if (!globalThis.fetch) {
         import('node-fetch').then(({ default: fetch, Headers, Request, Response }) => {
-            Object.assign(globalThis, { fetch, Headers, Request, Response })
+            Object.assign(globalThis, { fetch, Headers, Request, Response });
-        })
+        });
     }
 }
 
 module.exports = function(RED) {
     // disable logging if set to "off"
     let loggingSettings = RED.settings.get('logging');
-    if(
+    if (
         typeof loggingSettings.console !== 'undefined' &&
         typeof loggingSettings.console.level !== 'undefined' &&
         ['info','debug','trace'].indexOf(loggingSettings.console.level.toLowerCase()) >= 0
     ) {
-        const { logger } = require('matrix-js-sdk/lib/logger');
+        import('matrix-js-sdk/lib/logger.js')
-        logger.disableAll();
+            .then(({ logger }) => {
+                logger.disableAll();
+            })
+            .catch((err) => {
+                console.error("Error loading logger module:", err);
+            });
     }
 
     function MatrixFolderNameFromUserId(name) {
@@ -56,10 +75,11 @@ module.exports = function(RED) {
         this.autoAcceptRoomInvites = n.autoAcceptRoomInvites;
         this.e2ee = n.enableE2ee || false;
         this.globalAccess = n.global;
+        this.allowUnknownDevices = n.allowUnknownDevices || false;
         this.initializedAt = new Date();
         node.initialSyncLimit = 25;
 
-        // Keep track of all consumers of this node to be able to catch errors
+        // Keep track of all consumers of this node to catch errors
         node.register = function(consumerNode) {
             node.users[consumerNode.id] = consumerNode;
         };
@@ -99,7 +119,7 @@ module.exports = function(RED) {
                                 device_id = this.matrixClient.getDeviceId();
 
                             if(!device_id && node.enableE2ee) {
-                                node.error("Failed to auto detect deviceId for this auth token. You will need to manually specify one. You may need to login to create a new deviceId.", {})
+                                node.error("Failed to auto detect deviceId for this auth token. You will need to manually specify one. You may need to login to create a new deviceId.", {});
                             } else {
                                 if(!stored_device_id || stored_device_id !== device_id) {
                                     node.log(`Saving Device ID (old:${stored_device_id} new:${device_id})`);
@@ -116,7 +136,7 @@ module.exports = function(RED) {
                                                     node.matrixClient.setDeviceDetails(device_id, {
                                                         display_name: node.deviceLabel
                                                     }).then(
-                                                        function(response) {},
+                                                        function() {},
                                                         function(error) {
                                                             node.error("Failed to set device label: " + error, {});
                                                         }
@@ -153,9 +173,7 @@ module.exports = function(RED) {
                     localStorage: localStorage,
                 }),
                 userId: this.userId,
-                deviceId: (this.deviceId || getStoredDeviceId(localStorage)) || undefined,
+                deviceId: (this.deviceId || getStoredDeviceId(localStorage)) || undefined
-                request
-                // verificationMethods: ["m.sas.v1"]
             });
 
             node.debug(`hasLazyLoadMembersEnabled=${node.matrixClient.hasLazyLoadMembersEnabled()}`);
@@ -181,7 +199,7 @@ module.exports = function(RED) {
                 if(node.globalAccess) {
                     try {
                         node.context().global.set('matrixClient["'+node.userId+'"]', undefined);
-                    } catch(e){
+                    } catch(e) {
                         node.error(e.message, {});
                     }
                 }
@@ -195,15 +213,15 @@ module.exports = function(RED) {
             node.matrixClient.on(RoomEvent.Timeline, async function(event, room, toStartOfTimeline, removed, data) {
                 if (toStartOfTimeline) {
                     node.log("Ignoring" + (event.isEncrypted() ? ' encrypted' : '') +" timeline event [" + (event.getContent()['msgtype'] || event.getType()) + "]: (" + room.name + ") " + event.getId() + " for reason: paginated result");
-                    return; // ignore paginated results
+                    return;
                 }
                 if (!data || !data.liveEvent) {
                     node.log("Ignoring" + (event.isEncrypted() ? ' encrypted' : '') +" timeline event [" + (event.getContent()['msgtype'] || event.getType()) + "]: (" + room.name + ") " + event.getId() + " for reason: old message");
-                    return; // ignore old message (we only want live events)
+                    return;
                 }
                 if(node.initializedAt > event.getDate()) {
                     node.log("Ignoring" + (event.isEncrypted() ? ' encrypted' : '') +" timeline event [" + (event.getContent()['msgtype'] || event.getType()) + "]: (" + room.name + ") " + event.getId() + " for reason: old message before init");
-                    return; // skip events that occurred before our client initialized
+                    return;
                 }
 
                 try {
@@ -378,7 +396,6 @@ module.exports = function(RED) {
                 }
             });
 
-
             node.matrixClient.on(HttpApiEvent.SessionLoggedOut, async function(errorObj){
                 // Example if user auth token incorrect:
                 // {
@@ -401,6 +418,7 @@ module.exports = function(RED) {
                         node.log("Initializing crypto...");
                         await node.matrixClient.initCrypto();
                         node.matrixClient.getCrypto().globalBlacklistUnverifiedDevices = false; // prevent errors from unverified devices
+                        node.matrixClient.getCrypto().globalErrorOnUnknownDevices  = !node.allowUnknownDevices;
                     }
                     node.log("Connecting to Matrix server...");
                     await node.matrixClient.startClient({
@@ -450,7 +468,7 @@ module.exports = function(RED) {
                                 node.error("Auth check failed: " + err, {});
                             }
                         }
-                    )
+                    );
             })();
         }
     }
@@ -475,20 +493,21 @@ module.exports = function(RED) {
                 deviceId = req.body.deviceId || undefined,
                 displayName = req.body.displayName || undefined;
 
-            const matrixClient = sdk.createClient({
+            (async () => {
-                baseUrl: baseUrl,
+                const mod = await import("matrix-js-sdk");
-                deviceId: deviceId,
+                const matrixClient = mod.createClient({
-                timelineSupport: true,
+                    baseUrl: baseUrl,
-                localTimeoutMs: '30000',
+                    deviceId: deviceId,
-                request
+                    timelineSupport: true,
-            });
+                    localTimeoutMs: '30000'
+                });
 
-            new TimelineWindow()
+                new TimelineWindow();  // from our top-level variable, but to keep minimal changes,
+                                       // you can just do: (await import("matrix-js-sdk")).TimelineWindow();
 
-            matrixClient.timelineSupport = true;
+                matrixClient.timelineSupport = true;
 
-            matrixClient.login(
+                matrixClient.login('m.login.password', {
-                'm.login.password', {
                     identifier: {
                         type: 'm.id.user',
                         user: userId,
@@ -496,23 +515,27 @@ module.exports = function(RED) {
                     password: password,
                     initial_device_display_name: displayName
                 })
-                .then(
+                    .then(
-                    function(response) {
+                        function(response) {
-                        res.json({
+                            res.json({
-                            'result': 'ok',
+                                'result': 'ok',
-                            'token': response.access_token,
+                                'token': response.access_token,
-                            'device_id': response.device_id,
+                                'device_id': response.device_id,
-                            'user_id': response.user_id,
+                                'user_id': response.user_id,
-                        });
+                            });
-                    },
+                        },
-                    function(err) {
+                        function(err) {
-                        res.json({
+                            res.json({
-                            'result': 'error',
+                                'result': 'error',
-                            'message': err
+                                'message': err
-                        });
+                            });
-                    }
+                        }
-                );
+                    );
-        });
+            })().catch(err => {
+                res.json({ result: 'error', message: err.toString() });
+            });
+        }
+    );
 
     function upgradeDirectoryIfNecessary(node, storageDir) {
         let oldStorageDir = './matrix-local-storage',
@@ -553,9 +576,6 @@ module.exports = function(RED) {
         }
     }
 
-    /**
-     * If a device ID is stored we will use that for the client
-     */
     function getStoredDeviceId(localStorage) {
         let deviceId = localStorage.getItem('my_device_id');
         if(deviceId === "null" || !deviceId) {
@@ -571,4 +591,4 @@ module.exports = function(RED) {
         localStorage.setItem('my_device_id', deviceId);
         return true;
     }
-}
+};